linux-kernel - Re: [PATCH 2/2] misc: bm92txx: Add driver for the ROHM BM92Txx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOy33RB8aj3455ZQ@desktop>
Date:   Mon, 28 Aug 2023 17:06:05 +0200
From:   Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>,
        azkali <a.ffcc7@...il.com>, Adam Jiang <chaoj@...dia.com>,
        CTCaer <ctcaer@...il.com>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Derek Kiernan <derek.kiernan@....com>,
        Dragan Cvetic <dragan.cvetic@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] misc: bm92txx: Add driver for the ROHM BM92Txx

Hi,

On Thu, Aug 24, 2023 at 06:28:07PM +0200, Krzysztof Kozlowski wrote:
> On 24/08/2023 17:30, Emmanuel Gil Peyrot wrote:
> > From: azkali <a.ffcc7@...il.com>
> > 
> > This is used as the USB-C Power Delivery controller of the Nintendo
> > Switch.
> > 
> > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
> > Signed-off-by: azkali <a.ffcc7@...il.com>
> > Signed-off-by: Adam Jiang <chaoj@...dia.com>
> > Signed-off-by: CTCaer <ctcaer@...il.com>
> 
> These do not look like real identities. In this and previous patchset
> your author emails bounces, so I propose to drop all stale addresses and
> all anonymous entries.

I and the authors find that policy inacceptable, our work should be
credited and our copyright should hold despite our choice of name.

Given the amount of issues in this patchset I will drop it for now, we
will come back with a better patchset for this particular device in a
while.

> 
> Best regards,
> Krzysztof
> 

Thanks for the review, I already tried to clean it up but it was clearly
not as good as the expectations here.

-- 
Link Mauve