linux-kernel - Re: [GIT PULL] pstore updates for v6.6-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whbqsYC4nDc7HpWEYo7EnA603T35jSP4om6HMWpVZSc_w@mail.gmail.com>
Date:   Tue, 29 Aug 2023 10:13:20 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Kees Cook <kees@...nel.org>, linux-kernel@...r.kernel.org,
        Ard Biesheuvel <ardb@...nel.org>,
        Enlin Mu <enlin.mu@...soc.com>,
        Eric Biggers <ebiggers@...gle.com>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Yunlong Xing <yunlong.xing@...soc.com>,
        Yuxiao Zhang <yuxiaozhang@...gle.com>
Subject: Re: [GIT PULL] pstore updates for v6.6-rc1

On Mon, 28 Aug 2023 at 20:44, Kees Cook <keescook@...omium.org> wrote:
>
> On Mon, Aug 28, 2023 at 06:44:02PM -0700, Linus Torvalds wrote:
> > The only thing that is new is the kernel pstore implementation. Why
> > was this not a problem before? The warning existed back then too, but
> > I never actually got it.
>
> Right -- if the compression method from before was different, it'll fail
> now. (i.e. we removed everything but zlib.)

I don't think that was the case.

Looking back in my logs, I see lines like this:

  Aug 07 16:59:29 ryzen kernel: pstore: Using crash dump compression: deflate

and while it appears F37 used to support other formats, it does have

  CONFIG_PSTORE_DEFLATE_COMPRESS_DEFAULT=y

so it should all be zlib-compatible from what I can tell.

                  Linus