[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202308282035.5AFD431B@keescook>
Date: Mon, 28 Aug 2023 20:44:34 -0700
From: Kees Cook <keescook@...omium.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Kees Cook <kees@...nel.org>, linux-kernel@...r.kernel.org,
Ard Biesheuvel <ardb@...nel.org>,
Enlin Mu <enlin.mu@...soc.com>,
Eric Biggers <ebiggers@...gle.com>,
"Guilherme G. Piccoli" <gpiccoli@...lia.com>,
"Matthew Wilcox (Oracle)" <willy@...radead.org>,
Yunlong Xing <yunlong.xing@...soc.com>,
Yuxiao Zhang <yuxiaozhang@...gle.com>
Subject: Re: [GIT PULL] pstore updates for v6.6-rc1
On Mon, Aug 28, 2023 at 06:44:02PM -0700, Linus Torvalds wrote:
> The only thing that is new is the kernel pstore implementation. Why
> was this not a problem before? The warning existed back then too, but
> I never actually got it.
Right -- if the compression method from before was different, it'll fail
now. (i.e. we removed everything but zlib.)
> I get the feeling that you are overlooking that basic fact.
That's why I was wondering about the prior config; it could confirm the
default compression algo. But digging around it seems like zlib is the
default in the F37 kernel config. I'll keep looking; there is clearly
some combination I don't know.
I remain concerned about why there are 124. That's a LOT, and without
prior warnings, I don't know why systemd-pstore wasn't removing them.
Can you send me "ls -la /sys/fs/pstore" ? Maybe they aren't a dump type
that systemd knows about.
I will try to reproduce this with an F37 image...
--
Kees Cook
Powered by blists - more mailing lists