linux-kernel - Re: [GIT PULL] pstore updates for v6.6-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgaY2+_KyqVpRS+MrO6Y7bXQp69odTu7JT3XSpdUsgS=g@mail.gmail.com>
Date:   Tue, 29 Aug 2023 11:03:56 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Ard Biesheuvel <ardb@...nel.org>
Cc:     Kees Cook <keescook@...omium.org>, Kees Cook <kees@...nel.org>,
        linux-kernel@...r.kernel.org, Enlin Mu <enlin.mu@...soc.com>,
        Eric Biggers <ebiggers@...gle.com>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Yunlong Xing <yunlong.xing@...soc.com>,
        Yuxiao Zhang <yuxiaozhang@...gle.com>
Subject: Re: [GIT PULL] pstore updates for v6.6-rc1

On Tue, 29 Aug 2023 at 10:29, Ard Biesheuvel <ardb@...nel.org> wrote:
>
> This is an oversight on my part. The diff below plugs this into the pstore code

Hmm. My reaction is that you should also add the comment about the
"Work around a bug in zlib" issue, because this code makes no sense
otherwise.

Of course, potentially even better would be to actually move this fix
into our copy of zlib. Does the bug / misfeature still exist in
upstream zlib?

Also, grepping around a bit, I note that btrfs, for example, just does
that Z_SYNC_FLUSH, and then checks for Z_OK. None of this Z_STREAM_END
stuff.

Similarly, going off to the debian code search, I find other code that
just accepts either Z_OK or Z_STREAM_END.

So what's so magical about how pstore uses zlib? This is just very odd.

             Linus