[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <OS0PR01MB5922DAD6A4CC3AE8A5C25A1F86E7A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date: Tue, 29 Aug 2023 18:05:02 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Charles Keepax <ckeepax@...nsource.cirrus.com>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>,
"patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] ASoC: wm8580: Simplify probe()
Hi Andy,
> Subject: Re: [PATCH v2] ASoC: wm8580: Simplify probe()
>
> On Mon, Aug 28, 2023 at 06:40:19PM +0100, Biju Das wrote:
> > Simplify probe() by replacing of_match_device->i2c_get_match_data()
> > and extend matching support for ID table.
> >
> > While at it, remove comma in the terminator entry and simplify probe()
> > by replacing dev_err->dev_err_probe().
>
> dev_err() --> dev_err_probe()
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> ...
>
> > -static const struct of_device_id wm8580_of_match[] = {
> > - { .compatible = "wlf,wm8580", .data = &wm8580_data },
> > - { .compatible = "wlf,wm8581", .data = &wm8581_data },
> > - { },
> > -};
> > -MODULE_DEVICE_TABLE(of, wm8580_of_match);
>
> This doesn't change anything functional, please do it in a separate change.
Agreed.
Cheers,
Biju
Powered by blists - more mailing lists