linux-kernel - Re: [PATCH 4.14 00/57] 4.14.324-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <868cd8e3-2e7e-7b98-0a6e-e5586cb6ab0d@linaro.org>
Date:   Mon, 28 Aug 2023 21:01:41 -0600
From:   Daniel Díaz <daniel.diaz@...aro.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org
Cc:     patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
        nathanl@...ux.ibm.com, mpe@...erman.id.au
Subject: Re: [PATCH 4.14 00/57] 4.14.324-rc1 review

Hello!

On 28/08/23 4:12 a. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.324 release.
> There are 57 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Wed, 30 Aug 2023 10:11:30 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.324-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 
> -------------
> Pseudo-Shortlog of commits:
> 
> Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>      Linux 4.14.324-rc1
> 
[...]
> Nathan Lynch <nathanl@...ux.ibm.com>
>      powerpc/rtas_flash: allow user copy to flash block cache objects
[...]

We see this build regression on PowerPC with GCC-8 and GCC-12:
-----8<-----
   /builds/linux/arch/powerpc/kernel/rtas_flash.c: In function 'rtas_flash_init':
   /builds/linux/arch/powerpc/kernel/rtas_flash.c:717:22: error: implicit declaration of function 'kmem_cache_create_usercopy'; did you mean 'kmem_cache_create'? [-Werror=implicit-function-declaration]
     flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
                         kmem_cache_create
   /builds/linux/arch/powerpc/kernel/rtas_flash.c:717:20: error: assignment to 'struct kmem_cache *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
     flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
                       ^
----->8-----

That's on defconfig and cell_defconfig.

Bisection points to "powerpc/rtas_flash: allow user copy to flash block cache objects" (5190538c66e5). Reverting that patch makes the build pass again.

Tuxmake reproducer:

   #pip3 install -U tuxmake
   tuxmake --runtime podman --target-arch powerpc --toolchain gcc-8 --kconfig defconfig
   git revert 5190538c66e5e8e7cdbf694afec8291f421e6bcf
   tuxmake --runtime podman --target-arch powerpc --toolchain gcc-8 --kconfig defconfig

Greetings!

Daniel Díaz
daniel.diaz@...aro.org