linux-kernel - Re: [PATCH 4.14 00/57] 4.14.324-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bkeqysc0.fsf@li-e15d104c-2135-11b2-a85c-d7ef17e56be6.ibm.com>
Date:   Tue, 29 Aug 2023 06:57:03 -0500
From:   Nathan Lynch <nathanl@...ux.ibm.com>
To:     Daniel Díaz <daniel.diaz@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org
Cc:     patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
        mpe@...erman.id.au
Subject: Re: [PATCH 4.14 00/57] 4.14.324-rc1 review

Daniel Díaz <daniel.diaz@...aro.org> writes:
>
> We see this build regression on PowerPC with GCC-8 and GCC-12:
> -----8<-----
>    /builds/linux/arch/powerpc/kernel/rtas_flash.c: In function 'rtas_flash_init':
>    /builds/linux/arch/powerpc/kernel/rtas_flash.c:717:22: error: implicit declaration of function 'kmem_cache_create_usercopy'; did you mean 'kmem_cache_create'? [-Werror=implicit-function-declaration]
>      flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
>                          ^~~~~~~~~~~~~~~~~~~~~~~~~~
>                          kmem_cache_create
>    /builds/linux/arch/powerpc/kernel/rtas_flash.c:717:20: error: assignment to 'struct kmem_cache *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
>      flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
>                        ^
> ----->8-----
>
> That's on defconfig and cell_defconfig.
>
> Bisection points to "powerpc/rtas_flash: allow user copy to flash
> block cache objects" (5190538c66e5). Reverting that patch makes the
> build pass again.

That change should not be applied to 4.14.x. The problem it fixes is not
present in that version.