linux-kernel - Re: [PATCH] mmc: atmel-mci: Remove preprocessor directive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZKALgcN58Es_hKL1MyEKYaTezuRGyaMkkBYyfXhRpdKg@mail.gmail.com>
Date:   Tue, 29 Aug 2023 09:18:39 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Balamanikandan Gunasundar 
        <balamanikandan.gunasundar@...rochip.com>
Cc:     dmitry.torokhov@...il.com, ulf.hansson@...aro.org,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        ludovic.desroches@...rochip.com, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, hari.prasathge@...rochip.com
Subject: Re: [PATCH] mmc: atmel-mci: Remove preprocessor directive

On Mon, Aug 28, 2023 at 12:04 PM Balamanikandan Gunasundar
<balamanikandan.gunasundar@...rochip.com> wrote:

> Remove the preprocessor directive IS_ENABLED(CONFIG_MMC_ATMELMCI) while
> checking if the device is compatible with atmel,hsmci. Instead handle it in
> the if() condition. The compiler optimizes out the entire if() clause if
> the first expression in the if() clause is constant false.
>
> Signed-off-by: Balamanikandan Gunasundar <balamanikandan.gunasundar@...rochip.com>
> Suggested-by: Linus Walleij <linus.walleij@...aro.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Thanks for tidying this up Balamanikandan!

Yours,
Linus Walleij