linux-kernel - Re: [PATCH] mmc: atmel-mci: Remove preprocessor directive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFrX1JNBio1tm4TbOwO4KSGP5ZHsLbJEXVv8qn-2Cq_KJg@mail.gmail.com>
Date:   Thu, 14 Sep 2023 14:16:21 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Balamanikandan Gunasundar 
        <balamanikandan.gunasundar@...rochip.com>,
        dmitry.torokhov@...il.com, linux-kernel@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        ludovic.desroches@...rochip.com, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, hari.prasathge@...rochip.com
Subject: Re: [PATCH] mmc: atmel-mci: Remove preprocessor directive

On Tue, 29 Aug 2023 at 09:18, Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Mon, Aug 28, 2023 at 12:04 PM Balamanikandan Gunasundar
> <balamanikandan.gunasundar@...rochip.com> wrote:
>
> > Remove the preprocessor directive IS_ENABLED(CONFIG_MMC_ATMELMCI) while
> > checking if the device is compatible with atmel,hsmci. Instead handle it in
> > the if() condition. The compiler optimizes out the entire if() clause if
> > the first expression in the if() clause is constant false.
> >
> > Signed-off-by: Balamanikandan Gunasundar <balamanikandan.gunasundar@...rochip.com>
> > Suggested-by: Linus Walleij <linus.walleij@...aro.org>
>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
> Thanks for tidying this up Balamanikandan!

Linus, we didn't manage to get this into v6.6. So, it's probably
better if you pick up this via your tree for v6.7.

Note that the commit message header may be a bit misleading, as this
is really a gpio patch. Maybe you can amend that when applying?

Kind regards
Uffe