linux-kernel - Re: [PATCH] mmc: atmel-mci: Remove preprocessor directive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaAqG86XwO0FcKdgNggthW7=v2L=GfhUbr-dhc99tXxyw@mail.gmail.com>
Date:   Thu, 14 Sep 2023 15:49:21 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Cc:     Balamanikandan Gunasundar 
        <balamanikandan.gunasundar@...rochip.com>,
        dmitry.torokhov@...il.com, linux-kernel@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        ludovic.desroches@...rochip.com, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, hari.prasathge@...rochip.com
Subject: Re: [PATCH] mmc: atmel-mci: Remove preprocessor directive

On Thu, Sep 14, 2023 at 2:16 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:
> On Tue, 29 Aug 2023 at 09:18, Linus Walleij <linus.walleij@...aro.org> wrote:
> >
> > On Mon, Aug 28, 2023 at 12:04 PM Balamanikandan Gunasundar
> > <balamanikandan.gunasundar@...rochip.com> wrote:
> >
> > > Remove the preprocessor directive IS_ENABLED(CONFIG_MMC_ATMELMCI) while
> > > checking if the device is compatible with atmel,hsmci. Instead handle it in
> > > the if() condition. The compiler optimizes out the entire if() clause if
> > > the first expression in the if() clause is constant false.
> > >
> > > Signed-off-by: Balamanikandan Gunasundar <balamanikandan.gunasundar@...rochip.com>
> > > Suggested-by: Linus Walleij <linus.walleij@...aro.org>
> >
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> >
> > Thanks for tidying this up Balamanikandan!
>
> Linus, we didn't manage to get this into v6.6. So, it's probably
> better if you pick up this via your tree for v6.7.

Oh it's actually Bartosz managing the GPIO tree these days.
(Which I am very happy about!)

The best is to resend the patch to the GPIO maintainers and
linux-gpio@...r.

Yours,
Linus Walleij