linux-kernel - Re: [PATCH 5/8] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30eece756f273881b276f8069ab30692ded5af49.camel@infradead.org>
Date:   Thu, 14 Sep 2023 15:51:18 +0200
From:   David Woodhouse <dwmw2@...radead.org>
To:     Paul Durrant <paul@....org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Paul Durrant <pdurrant@...zon.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH 5/8] KVM: pfncache: allow a cache to be activated with a
 fixed (userspace) HVA

On Thu, 2023-09-14 at 08:49 +0000, Paul Durrant wrote:
> --- a/include/linux/kvm_types.h
> +++ b/include/linux/kvm_types.h
> @@ -64,7 +64,8 @@ struct gfn_to_hva_cache {
>  
>  struct gfn_to_pfn_cache {
>         u64 generation;
> -       gpa_t gpa;
> +       unsigned long addr;

On 32-bit hosts gpa_t is 64 bits and doesn't fit in an 'unsigned long'

> +       bool addr_is_gpa;

Don't put that there. There are already bools at the end of the struct
which wouldn't leave 63 bits of padding.


Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)