linux-kernel - Re: [PATCH 5/8] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8419c105-205a-bd25-b84a-ed81a9447bd1@xen.org>
Date:   Thu, 14 Sep 2023 15:58:11 +0200
From:   Paul Durrant <xadimgnik@...il.com>
To:     David Woodhouse <dwmw2@...radead.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Paul Durrant <pdurrant@...zon.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH 5/8] KVM: pfncache: allow a cache to be activated with a
 fixed (userspace) HVA

On 14/09/2023 14:51, David Woodhouse wrote:
> On Thu, 2023-09-14 at 08:49 +0000, Paul Durrant wrote:
>> --- a/include/linux/kvm_types.h
>> +++ b/include/linux/kvm_types.h
>> @@ -64,7 +64,8 @@ struct gfn_to_hva_cache {
>>   
>>   struct gfn_to_pfn_cache {
>>          u64 generation;
>> -       gpa_t gpa;
>> +       unsigned long addr;
> 
> On 32-bit hosts gpa_t is 64 bits and doesn't fit in an 'unsigned long'
> 

Damn. So used to the host only ever being 64-bit. A u64 it is then.

>> +       bool addr_is_gpa;
> 
> Don't put that there. There are already bools at the end of the struct
> which wouldn't leave 63 bits of padding.
> 

True. Will move.

   Paul