[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJpopJJdkxiy1pN3oZqZ4sqTAzyHLyB-1yUTi4TFja6kA-g@mail.gmail.com>
Date: Tue, 29 Aug 2023 12:03:44 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, catalin.marinas@....com, will@...nel.org,
vkoul@...nel.org, kishon@...nel.org, arnd@...db.de,
geert+renesas@...der.be, nfraprado@...labora.com, rafal@...ecki.pl,
peng.fan@....com, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org
Subject: Re: [PATCH v10 3/4] arm64: dts: qcom: ipq5332: Enable USB
On Tue, 29 Aug 2023 at 11:39, Varadarajan Narayanan
<quic_varada@...cinc.com> wrote:
>
> Enable USB2 in host mode.
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
> v10:
> regulator_s0500 -> regulator-s0500
> "make W=1 ARCH=arm64 -j 16 CHECK_DTBS=y DT_SCHEMA_FILES=qcom,ipq5332-usb-hsphy.yaml dtbs_check" passed
> v9:
> regulator_fixed_5p0: s0500 -> regulator_fixed_5p0: regulator_s0500
> "make ARCH=arm64 -j 16 CHECK_DTBS=y DT_SCHEMA_FILES=qcom,ipq5332-usb-hsphy.yaml dtbs_check" passed
> v6:
> Add vdd-supply and corresponding regulator
> v1:
> Enable usb-phy node
> ---
> arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> index f96b0c8..1fe2e39 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> @@ -12,6 +12,15 @@
> / {
> model = "Qualcomm Technologies, Inc. IPQ5332 MI01.6";
> compatible = "qcom,ipq5332-ap-mi01.6", "qcom,ipq5332";
> +
> + regulator_fixed_5p0: regulator-s0500 {
> + compatible = "regulator-fixed";
> + regulator-min-microvolt = <500000>;
> + regulator-max-microvolt = <500000>;
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-name = "fixed_5p0";
> + };
> };
>
> &blsp1_spi0 {
> @@ -79,3 +88,17 @@
> bias-pull-up;
> };
> };
> +
> +&usbphy0 {
> + vdd-supply = <®ulator_fixed_5p0>;
> +
> + status = "okay";
> +};
> +
> +&usb {
> + status = "okay";
> +};
> +
> +&usb2_0_dwc {
> + dr_mode = "host";
> +};
This is not sorted properly. If we follow alphanumeric sorting order,
it should be:
- usb
- usb2_0_dwc
- usbphy0
> --
> 2.7.4
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists