[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7ec87a0f-3404-46b3-be18-e7af870e6411@linaro.org>
Date: Tue, 29 Aug 2023 12:31:36 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>, agross@...nel.org,
andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
catalin.marinas@....com, will@...nel.org, vkoul@...nel.org,
kishon@...nel.org, arnd@...db.de, geert+renesas@...der.be,
nfraprado@...labora.com, rafal@...ecki.pl, peng.fan@....com,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-phy@...ts.infradead.org
Subject: Re: [PATCH v10 1/4] phy: qcom: m31: Fix indentation issues
On 29/08/2023 11:37, Varadarajan Narayanan wrote:
> Fix incorrect indentation
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
> v10:
> Restore register success print per Dmitry's comment
> v9:
> Fix line break alignment
> Remove register success print
> v8 version of the driver has been picked up for merge.
> (https://lore.kernel.org/linux-arm-msm/169226613917.81413.1200008047604336868.b4-ty@kernel.org/)
> v8:
> Change commit subject and message per review comments
> Don't include of_platform.h
> Change struct init coding style
> GENMASK -> BIT for one define
> v6:
> Kconfig:Add COMPILE_TEST and remove USB_GADGET from 'depends'
> Change 'selects' USB_PHY -> GENERIC_PHY
> Driver: Use correct headers
> const int -> unsigned int for 'nregs' in private data
> Use generic names for clk, phy in m31 phy structure
> Init register details directly instead of using macro
> Use dev_err_probe in the error paths of driver probe
> v5:
> Kconfig and Makefile:- place snippet according to sorted order
> Use generic phy instead of usb-phy
> Use ARRAY_SIZE for reg init instead of blank last entry
> Fix copyright year
>
> v4:
> Remove unused enum
> Error handling for devm_clk_get
> v1:
> Combine driver, makefile and kconfig into 1 patch
> Remove 'qscratch' region and its usage. The controller driver takes care
> of those settings
> Use compatible/data to handle ipq5332 init
> Drop the default case
> Get resources by index instead of name as there is only one resource
> Add clock
> Fix review comments in the driver
> ---
> drivers/phy/qualcomm/phy-qcom-m31.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
--
With best wishes
Dmitry
Powered by blists - more mailing lists