linux-kernel - Re: [RFC PATCH v2 0/3] Move usages of struct __call_single_data to call_single_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Aug 2023 21:55:58 -0300
From:   Leonardo Brás <leobras@...hat.com>
To:     Jens Axboe <axboe@...nel.dk>,
        Peter Zijlstra <peterz@...radead.org>,
        Josh Poimboeuf <jpoimboe@...nel.org>,
        Palmer Dabbelt <palmer@...osinc.com>,
        Guo Ren <guoren@...nel.org>,
        Valentin Schneider <vschneid@...hat.com>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Juergen Gross <jgross@...e.com>,
        Yury Norov <yury.norov@...il.com>,
        Marcelo Tosatti <mtosatti@...hat.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 0/3] Move usages of struct __call_single_data to
 call_single_data_t

On Tue, 2023-07-04 at 04:22 -0300, Leonardo Brás wrote:
> On Tue, 2023-06-13 at 00:51 -0300, Leonardo Bras Soares Passos wrote:
> > Friendly ping
> > 
> > On Sat, May 20, 2023 at 2:30 AM Leonardo Bras <leobras@...hat.com> wrote:
> > > 
> > > Changes since RFCv1:
> > > - request->csd moved to the middle of the struct, without size impact
> > > - type change happens in a different patch (thanks Jens Axboe!)
> > > - Improved the third patch to also update the .h file.
> > > 
> > > Leonardo Bras (3):
> > >   blk-mq: Move csd inside struct request so it's 32-byte aligned
> > >   blk-mq: Change request->csd type to call_single_data_t
> > >   smp: Change signatures to use call_single_data_t
> > > 
> > >  include/linux/blk-mq.h | 10 +++++-----
> > >  include/linux/smp.h    |  2 +-
> > >  kernel/smp.c           |  4 ++--
> > >  kernel/up.c            |  2 +-
> > >  4 files changed, 9 insertions(+), 9 deletions(-)
> > > 
> > > --
> > > 2.40.1
> > > 
> 
> Hello Jens,
> 
> I still want your feedback on this series :)
> 
> I think I addressed every issue of RFCv1, but if you have any other feedback,
> please let me know.
> 
> Thanks!
> Leo

Hello Jens Axboe,

Please provide feedback on this series!

Are you ok with those changes?
What's your opinion on them? 

Thanks!
Leo