linux-kernel - Re: [PATCH v1 2/3] perf parse-events: Make common term list to strbuf helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVhEe7N+BQ+8MngjqxRXDBoo6xy065zTn_hdO1CRDTtLw@mail.gmail.com>
Date:   Wed, 30 Aug 2023 14:12:47 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     "Liang, Kan" <kan.liang@...ux.intel.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        James Clark <james.clark@....com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/3] perf parse-events: Make common term list to strbuf helper

On Wed, Aug 30, 2023 at 12:35 PM Liang, Kan <kan.liang@...ux.intel.com> wrote:
>
>
>
> On 2023-08-30 2:29 p.m., Liang, Kan wrote:
> >> The problem
> >> is how we encode terms of an event name, it is indistinguishable when
> >> the of the user field is 1. I'll probably add something to fix this
> >> later, but it only impacts debug output and perf list, so I'm not
> >> overly worried.
> > It should be OK for the debug output.
> >
>
> Not just the debug output. It also impacts the perf list --detail.
>
> With the patch,
> perf list --detail | grep uops_retired.heavy -A 2
>   uops_retired.heavy
>        [Retired uops except the last uop of each instruction. Unit:
> cpu_core]
>         cpu_core/event=0xc2,period=0x1e8483,umask/
>
> Without the patch,
> perf list --detail | grep uops_retired.heavy -A 2
>   uops_retired.heavy
>        [Retired uops except the last uop of each instruction. Unit:
> cpu_core]
>         cpu_core/event=0xc2,period=0x1e8483,umask=0x1/

Right, nobody uses --detail ;-) I'll write the fix.

Thanks,
Ian

> Thanks,
> Kan
>
>
>