linux-kernel - Re: [PATCH v1 1/3] perf parse-events: Minor help message improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3eda8956-f131-3772-1df5-c7c0fb7335f9@linux.intel.com>
Date:   Thu, 31 Aug 2023 14:32:35 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        James Clark <james.clark@....com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] perf parse-events: Minor help message improvements


The other thread address the only issue I found when I tested the patch
series on a hybrid machine.
https://lore.kernel.org/lkml/c2affcc9-468f-bf4c-a080-65b31e05a83f@linux.intel.com/

The patch series looks good.

Tested-by: Kan Liang <kan.liang@...ux.intel.com>

Thanks,
Kan

On 2023-08-30 3:07 a.m., Ian Rogers wrote:
> Be more specific and fix a typo.
> 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/util/parse-events.y | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 3a9d4e2513b5..4a370c36a0d5 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -342,7 +342,7 @@ PE_NAME opt_pmu_config
>  			struct parse_events_error *error = parse_state->error;
>  			char *help;
>  
> -			if (asprintf(&help, "Unabled to find PMU or event on a PMU of '%s'", $1) < 0)
> +			if (asprintf(&help, "Unable to find PMU or event on a PMU of '%s'", $1) < 0)
>  				help = NULL;
>  			parse_events_error__handle(error, @1.first_column,
>  						   strdup("Bad event or PMU"),
> @@ -368,7 +368,7 @@ PE_NAME sep_dc
>  		struct parse_events_error *error = parse_state->error;
>  		char *help;
>  
> -		if (asprintf(&help, "Unabled to find PMU or event on a PMU of '%s'", $1) < 0)
> +		if (asprintf(&help, "Unable to find event on a PMU of '%s'", $1) < 0)
>  			help = NULL;
>  		parse_events_error__handle(error, @1.first_column, strdup("Bad event name"), help);
>  		free($1);