linux-kernel - Re: [PATCH v3 00/10] media: qcom: camss: Bugfix series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230830204732.GQ6477@pendragon.ideasonboard.com>
Date:   Wed, 30 Aug 2023 23:47:32 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc:     rfoss@...nel.org, todor.too@...il.com, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org, mchehab@...nel.org,
        hverkuil-cisco@...all.nl, sakari.ailus@...ux.intel.com,
        andrey.konovalov@...aro.org, linux-media@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 00/10] media: qcom: camss: Bugfix series

Hi Bryan,

I wanted to let you know that I will likely not be able to review this
v3 in a timely manner. v2 was quite fine overall, I trust that you've
taken my review comments into account in this new version. Maybe someone
else could give it another look, in order to get it merged in v6.7 ?

On Wed, Aug 30, 2023 at 04:16:05PM +0100, Bryan O'Donoghue wrote:
> V3:
> - Adds Reviewed-by where indicated - Laurent
> - Adds a new patch for genpd cleanup. TBH I completely missed this so thanks ! - Laurent
> - "media: qcom: camss: Fix V4L2 async notifier error path" stays the same fixes spalt in -next
>   Fixes: 51397a4ec75d ("media: qcom: Initialise V4L2 async notifier later")
> - I like the suggesting of using a common fix for vfe-17x and vfe-480 however, I believe
>   we need to support multiple write-master/RDI => VCs in 17x which currently we only do
>   in vfe-480 so sharing the code between the two here right now, is	n't possible.
> - Included other suggestions on vfe-17x and vfe-480 - Laurent
> - I didn't change the val |= 1 << CSI2_RX_CFG1_VC_MODE to BIT(2)
>   The reason for that is all of the code uses this odd bit-shifting and I'd rather do
>   the conversion from shifting to BIT(x) as a distinct series instead of piecemeal - bod
> 
> V2:
> - Amends commit log for TPG fix to cover dropping of fixed
>   VC when setting up a TPG - Konrad
> 
> - Leaves GENMASK etc out. I'm happy to do a "make it pretty"
>   series later on. - bod
> 
> Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/commits/Bugfix-series-v2?ref_type=tags
> 
> V1:
> - Drops dt_id = vc * 4 in favour of a patch in a later series - Hans
>   Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/commit/d4c382c5d6ee153b410a01e172b3e811011d0b14
> - Adds Konrad's Acked-by as indicated
> 
> V0:
> This series covers a number of Fixes: all of which are for application to
> stable as well as -next with the exception of the second patch which is a
> fix for a SHA that is still in -next.
> 
> Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-23-08-07-db410c-rb3-camss-dts-v3
> 
> This series is part of a larger set of fixes, improvements developed/found
> when adding a new SoC.
> 
> Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/lenovo-x13s-v6.5-rc4-x13s-camss-patches
> 
> First pass on that larger series is to get all of the current Fixes: in the
> branch out.
> 
> Andrey Konovalov (1):
>   media: qcom: camss: Fix csid-gen2 for test pattern generator
> 
> Bryan O'Donoghue (9):
>   media: qcom: camss: Fix pm_domain_on sequence in probe
>   media: qcom: camss: Fix V4L2 async notifier error path
>   media: qcom: camss: Fix genpd cleanup
>   media: qcom: camss: Fix vfe_get() error jump
>   media: qcom: camss: Fix VFE-17x vfe_disable_output()
>   media: qcom: camss: Fix VFE-480 vfe_disable_output()
>   media: qcom: camss: Fix missing vfe_lite clocks check
>   media: qcom: camss: Fix invalid clock enable bit disjunction
>   media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater
>     than 3
> 
>  .../platform/qcom/camss/camss-csid-gen2.c     | 11 ++--
>  .../qcom/camss/camss-csiphy-3ph-1-0.c         |  2 +-
>  .../media/platform/qcom/camss/camss-vfe-170.c | 22 +-------
>  .../media/platform/qcom/camss/camss-vfe-480.c | 22 +-------
>  drivers/media/platform/qcom/camss/camss-vfe.c |  5 +-
>  drivers/media/platform/qcom/camss/camss.c     | 55 +++++++++++--------
>  6 files changed, 46 insertions(+), 71 deletions(-)

-- 
Regards,

Laurent Pinchart