linux-kernel - Re: [PATCH blktests v3 3/3] nvme: introduce nvmet_target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <o5xnqvujzakhrudv7p64owiuzgozmean6blxow4vdxhdqozg5v@qznf2tzmey7k>
Date:   Wed, 30 Aug 2023 01:19:14 +0000
From:   Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To:     Bart Van Assche <bvanassche@....org>
CC:     Daniel Wagner <dwagner@...e.de>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Hannes Reinecke <hare@...e.de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH blktests v3 3/3] nvme: introduce
 nvmet_target_{setup/cleanup} common code

On Aug 29, 2023 / 06:35, Bart Van Assche wrote:
> On 8/28/23 19:11, Shinichiro Kawasaki wrote:
> > This is the unclear point for me. Does bash really pass the arguments list of
> > the caller to the callee when functions are called without arguments?
> > 
> > Looking back the commit 852996fea4f1, you explained that bash does, and I
> > agreed. But now in my environment bash doesn't. I tried the script below in my
> > environment, and see nothing printed.
> > 
> >    funcA() { echo "$1" ; }
> >    funcB() { funcA; }
> >    funcB foo
> > 
> > Then the arguments of funcB is not passed to funcA. How does it run in your
> > environment?
> 
> I see the same result that you see. It seems that I misinterpret the text
> produced by shellcheck if it reports warning SC2119. After having reread
> https://github.com/koalaman/shellcheck/wiki/SC2119, I'm OK with
> suppressing warning SC2119 because that warning doesn't seem useful to
> me.

Thank you for confirmation. It's good that we clarified this confusing point :)
I will revert the 26664dff17b6 ("Do not suppress any shellcheck warnings") to
suppress SC2119.

Later on, I'll create a clean-up-patch for SC2119 which will revert relevant
commits 852996fea4f1 and 45b203cce8b (partially for the latter).

Daniel, let's go ahead with current approach: allow calling _nvmet_target_setup
without arguments.