linux-kernel - Re: [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230830113421.GBZO8pPUILVoBUVlki@fat_crate.local>
Date:   Wed, 30 Aug 2023 13:34:21 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Shravan Kumar Ramani <shravankr@...dia.com>
Cc:     James Morse <james.morse@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access

On Wed, Aug 30, 2023 at 06:56:14AM -0400, Shravan Kumar Ramani wrote:
> Add secure read/write calls (arm_smccc_smc) to bluefield_edac.
> The ACPI table entry decides whether SMC is need for accessing

SMC? Self-Modifying Code?

> the registers in the External Memory Interface block. If not,
> the registers may be mapped and accessed directly.

I'm sure there's a human readable explanation for the above.

> v0 -> v1
> Updated commit message

I still have no clue what those secure calls are.

I'm sure there's some ARM documentation which you use in order to
explain why those are needed.

> +static int edac_readl(void __iomem *addr, uint32_t *result,

No "edac_" previxes to driver-local functions. They belong to the EDAC
subsystem.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette