linux-kernel - Re: [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM4PR12MB5136B7483D9E76625B2BDCA1C0E5A@DM4PR12MB5136.namprd12.prod.outlook.com>
Date:   Thu, 31 Aug 2023 04:31:23 +0000
From:   Shravan Ramani <shravankr@...dia.com>
To:     Borislav Petkov <bp@...en8.de>
CC:     James Morse <james.morse@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access

>> Add secure read/write calls (arm_smccc_smc) to bluefield_edac.
>> The ACPI table entry decides whether SMC is need for accessing
>
> SMC? Self-Modifying Code?

SMC stands for Secure Monitor Call. ARM documentation can be found
here: https://developer.arm.com/documentation/den0028/latest/

SMC is needed by the driver to access certain HW blocks/registers which
can be accessed only from secure state. Whether a certain block requires
these secure calls or not is encoded in the ACPI table entry and passed
on to the driver.

>
>> +static int edac_readl(void __iomem *addr, uint32_t *result,
>
> No "edac_" previxes to driver-local functions. They belong to the EDAC
> subsystem.

Ack, will change the prefixes in v2.

Thanks,
Shravan