linux-kernel - Re: [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230901073823.GAZPGU75L6YEPGopLb@fat_crate.local>
Date:   Fri, 1 Sep 2023 09:38:23 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Shravan Ramani <shravankr@...dia.com>
Cc:     James Morse <james.morse@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access

On Thu, Aug 31, 2023 at 04:31:23AM +0000, Shravan Ramani wrote:
> SMC is needed by the driver to access certain HW blocks/registers which
> can be accessed only from secure state. Whether a certain block requires
> these secure calls or not is encoded in the ACPI table entry and passed
> on to the driver.

This sounds like a good start towards explaining why this patch is
needed. Here's an example commit message structure:

1. Prepare the context for the explanation briefly.

2. Explain the problem at hand.

3. "It happens because of <...>"

4. "Fix it by doing X"

5. "(Potentially do Y)."

For more detailed info, see
Documentation/process/submitting-patches.rst, Section "2) Describe your
changes".

Do not talk about what your patch does - that should (hopefully) be
visible from the diff itself. Rather, talk about *why* you're doing what
you're doing.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette