[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c498fd06-f99d-6dc8-2c22-c332a5b6084d@quicinc.com>
Date: Thu, 31 Aug 2023 13:29:42 -0700
From: Kuogee Hsieh <quic_khsieh@...cinc.com>
To: Stephen Boyd <swboyd@...omium.org>,
Rob Clark <robdclark@...il.com>,
Abhinav Kumar <quic_abhinavk@...cinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: <linux-kernel@...r.kernel.org>, <patches@...ts.linux.dev>,
Sean Paul <sean@...rly.run>, <dri-devel@...ts.freedesktop.org>,
<freedreno@...ts.freedesktop.org>,
Vinod Polimera <quic_vpolimer@...cinc.com>
Subject: Re: [PATCH 7/7] drm/msm/dp: Remove dp_display_is_ds_bridge()
On 8/29/2023 11:47 AM, Stephen Boyd wrote:
> This function is simply drm_dp_is_branch() so use that instead of
> open-coding it.
>
> Cc: Vinod Polimera <quic_vpolimer@...cinc.com>
> Cc: Kuogee Hsieh <quic_khsieh@...cinc.com>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
Tested-by: Kuogee Hsieh <quic_khsieh@...cinc.com>
Reviewed-by: Kuogee Hsieh <quic_khsieh@...cinc.com>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index 76f13954015b..96bbf6fec2f1 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -341,19 +341,12 @@ static const struct component_ops dp_display_comp_ops = {
> .unbind = dp_display_unbind,
> };
>
> -static bool dp_display_is_ds_bridge(struct dp_panel *panel)
> -{
> - return (panel->dpcd[DP_DOWNSTREAMPORT_PRESENT] &
> - DP_DWN_STRM_PORT_PRESENT);
> -}
> -
> static bool dp_display_is_sink_count_zero(struct dp_display_private *dp)
> {
> drm_dbg_dp(dp->drm_dev, "present=%#x sink_count=%d\n",
> dp->panel->dpcd[DP_DOWNSTREAMPORT_PRESENT],
> dp->link->sink_count);
> - return dp_display_is_ds_bridge(dp->panel) &&
> - (dp->link->sink_count == 0);
> + return drm_dp_is_branch(dp->panel->dpcd) && dp->link->sink_count == 0;
> }
>
> static void dp_display_send_hpd_event(struct msm_dp *dp_display)
Powered by blists - more mailing lists