linux-kernel - Re: [PATCH 4/7] drm/msm/dp: Remove aux_cfg_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c581ba5d-fa61-dfca-317f-3e2da95eac2a@quicinc.com>
Date:   Thu, 31 Aug 2023 13:28:47 -0700
From:   Kuogee Hsieh <quic_khsieh@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>,
        Rob Clark <robdclark@...il.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC:     <linux-kernel@...r.kernel.org>, <patches@...ts.linux.dev>,
        Sean Paul <sean@...rly.run>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>,
        Vinod Polimera <quic_vpolimer@...cinc.com>
Subject: Re: [PATCH 4/7] drm/msm/dp: Remove aux_cfg_update_done and related
 code


On 8/29/2023 11:47 AM, Stephen Boyd wrote:
> The member 'aux_cfg_update_done' is always false. This is dead code that
> never runs. Remove it.
>
> Cc: Vinod Polimera <quic_vpolimer@...cinc.com>
> Cc: Kuogee Hsieh <quic_khsieh@...cinc.com>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
Tested-by: Kuogee Hsieh <quic_khsieh@...cinc.com>
Reviewed-by: Kuogee Hsieh <quic_khsieh@...cinc.com>
> ---
>   drivers/gpu/drm/msm/dp/dp_panel.c | 15 ---------------
>   1 file changed, 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
> index 9fb4e963fefb..0893522ae158 100644
> --- a/drivers/gpu/drm/msm/dp/dp_panel.c
> +++ b/drivers/gpu/drm/msm/dp/dp_panel.c
> @@ -17,7 +17,6 @@ struct dp_panel_private {
>   	struct dp_link *link;
>   	struct dp_catalog *catalog;
>   	bool panel_on;
> -	bool aux_cfg_update_done;
>   };
>   
>   static void dp_panel_read_psr_cap(struct dp_panel_private *panel)
> @@ -177,19 +176,6 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel,
>   		}
>   	}
>   
> -	if (panel->aux_cfg_update_done) {
> -		drm_dbg_dp(panel->drm_dev,
> -				"read DPCD with updated AUX config\n");
> -		rc = dp_panel_read_dpcd(dp_panel);
> -		bw_code = drm_dp_link_rate_to_bw_code(dp_panel->link_info.rate);
> -		if (rc || !is_link_rate_valid(bw_code) ||
> -			!is_lane_count_valid(dp_panel->link_info.num_lanes)
> -			|| (bw_code > dp_panel->max_bw_code)) {
> -			DRM_ERROR("read dpcd failed %d\n", rc);
> -			return rc;
> -		}
> -		panel->aux_cfg_update_done = false;
> -	}
>   end:
>   	return rc;
>   }
> @@ -434,7 +420,6 @@ struct dp_panel *dp_panel_get(struct dp_panel_in *in)
>   
>   	dp_panel = &panel->dp_panel;
>   	dp_panel->max_bw_code = DP_LINK_BW_8_1;
> -	panel->aux_cfg_update_done = false;
>   
>   	return dp_panel;
>   }