linux-kernel - Re: [PATCH] drm/amd/display: remove useless check in should_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_NvD3CC=awhR4jqSb3GNYQfdFZDk3XX7pVyJfeU06kqiQ@mail.gmail.com>
Date:   Thu, 31 Aug 2023 15:36:15 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Harry Wentland <harry.wentland@....com>
Cc:     Dembskiy Igor <dii@....spb.ru>,
        Alex Deucher <alexander.deucher@....com>,
        lvc-project@...uxtesting.org, Leo Li <sunpeng.li@....com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        hersen wu <hersenxs.wu@....com>, amd-gfx@...ts.freedesktop.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>
Subject: Re: [PATCH] drm/amd/display: remove useless check in should_enable_fbc()

Applied.  Thanks!

Alex

On Thu, Aug 31, 2023 at 2:48 PM Harry Wentland <harry.wentland@....com> wrote:
>
> On 2023-08-30 10:01, Dembskiy Igor wrote:
> > It does not make sense to compare a pointer to array element with NULL.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes: 65d38262b3e8 ("drm/amd/display: fbc state could not reach while enable fbc")
> > Signed-off-by: Dembskiy Igor <dii@....spb.ru>
>
> Reviewed-by: Harry Wentland <harry.wentland@....com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > index 6966420dfbac..e87cf54ec658 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > @@ -1992,9 +1992,6 @@ static bool should_enable_fbc(struct dc *dc,
> >
> >                       pipe_ctx = &res_ctx->pipe_ctx[i];
> >
> > -                     if (!pipe_ctx)
> > -                             continue;
> > -
> >                       /* fbc not applicable on underlay pipe */
> >                       if (pipe_ctx->pipe_idx != underlay_idx) {
> >                               *pipe_idx = i;
>