linux-kernel - Re: [PATCH v2 3/3] kconfig: add dependencies of POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <068519AD74A8CD7C+60cefdac-3b62-4df4-b973-38210f95f630@tinylab.org>
Date:   Sat, 2 Sep 2023 02:02:43 +0800
From:   Yuan Tan <tanyuan@...ylab.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "tsbogend@...ha.franken.de" <tsbogend@...ha.franken.de>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>
Cc:     "linux@...ssschuh.net" <linux@...ssschuh.net>,
        "w@....eu" <w@....eu>, "falcon@...ylab.org" <falcon@...ylab.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH v2 3/3] kconfig: add dependencies of POWER_RESET for
 PowerMac

Hi,

On 9/1/2023 2:10 PM, Christophe Leroy wrote:
>
> Le 01/09/2023 à 04:43, Yuan Tan a écrit :
>> PowerMac's power off depends on ADB_CUDA to work. Enable it when
>> POWER_RESET is set for convenience.
>>
>> Suggested-by: Zhangjin Wu <falcon@...ylab.org>
>> Signed-off-by: Yuan Tan <tanyuan@...ylab.org>
>> ---
>>    arch/powerpc/platforms/powermac/Kconfig | 1 +
>>    1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig
>> index 130707ec9f99..9e633d7e8367 100644
>> --- a/arch/powerpc/platforms/powermac/Kconfig
>> +++ b/arch/powerpc/platforms/powermac/Kconfig
>> @@ -2,6 +2,7 @@
>>    config PPC_PMAC
>>    	bool "Apple PowerMac based machines"
>>    	depends on PPC_BOOK3S && CPU_BIG_ENDIAN
>> +	select ADB_CUDA if POWER_RESET
> ADB_CUDA depends on !PPC_PMAC64.
>
> What will happen if PPC_PMAC64 is selected ?
>
>>    	select MPIC
>>    	select FORCE_PCI
>>    	select PPC_INDIRECT_PCI if PPC32

I didn't notice that ADB_CUDA depends on !PPC_PMAC64. In the case where 
PPC_PMAC64 is set, ADB_CUDA indeed should not be enabled. Thank you for 
pointing that out.

I will fix it in v3 and check again in x86 and mips :)