[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <915a9e2d-36ea-4a74-7b1b-9688f215b6f1@linaro.org>
Date: Mon, 4 Sep 2023 09:40:14 +0200
From: Philippe Mathieu-Daudé <philmd@...aro.org>
To: Yuan Tan <tanyuan@...ylab.org>, mpe@...erman.id.au,
christophe.leroy@...roup.eu, tglx@...utronix.de, mingo@...hat.com,
tsbogend@...ha.franken.de, hdegoede@...hat.com
Cc: linux@...ssschuh.net, w@....eu, falcon@...ylab.org,
linux-mips@...r.kernel.org, x86@...nel.org,
linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 1/3] kconfig: add dependencies of POWER_RESET for mips
malta
Hi,
On 1/9/23 04:42, Yuan Tan wrote:
> MIPS Malta's power off depends on PCI, PCI_QUIRKS, and
> POWER_RESET_PIIX4_POWEROFF to work. Enable them when POWER_RESET is set
> for convenience.
>
> Suggested-by: Zhangjin Wu <falcon@...ylab.org>
> Signed-off-by: Yuan Tan <tanyuan@...ylab.org>
> ---
> arch/mips/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index bc8421859006..13bacbd05125 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -547,6 +547,9 @@ config MIPS_MALTA
> select MIPS_L1_CACHE_SHIFT_6
> select MIPS_MSC
> select PCI_GT64XXX_PCI0
> + select PCI if POWER_RESET
> + select PCI_QUIRKS if POWER_RESET
> + select POWER_RESET_PIIX4_POWEROFF if POWER_RESET
> select SMP_UP if SMP
> select SWAP_IO_SPACE
> select SYS_HAS_CPU_MIPS32_R1
Shouldn't we also update the _defconfig files?
Powered by blists - more mailing lists