linux-kernel - [PATCH] input: gpio-keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230903160349.3919-1-sensor1010@163.com>
Date:   Sun,  3 Sep 2023 09:03:49 -0700
From:   Lizhe <sensor1010@....com>
To:     dmitry.torokhov@...il.com, geert+renesas@...der.be,
        Jonathan.Cameron@...wei.com, soyer@....hu
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lizhe <sensor1010@....com>
Subject: [PATCH] input: gpio-keys - use spin_lock()

Use the spin_lock() and spin_unlock() instead of spin_lock_irqsave()
and spin_unlock_restore()

Signed-off-by: Lizhe <sensor1010@....com>
---
 drivers/input/keyboard/gpio_keys.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index c928829a8b0c..a55d62e1ff6d 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -468,11 +468,10 @@ static irqreturn_t gpio_keys_irq_isr(int irq, void *dev_id)
 {
 	struct gpio_button_data *bdata = dev_id;
 	struct input_dev *input = bdata->input;
-	unsigned long flags;
 
 	BUG_ON(irq != bdata->irq);
 
-	spin_lock_irqsave(&bdata->lock, flags);
+	spin_lock(&bdata->lock);
 
 	if (!bdata->key_pressed) {
 		if (bdata->button->wakeup)
@@ -495,7 +494,7 @@ static irqreturn_t gpio_keys_irq_isr(int irq, void *dev_id)
 			      ms_to_ktime(bdata->release_delay),
 			      HRTIMER_MODE_REL_HARD);
 out:
-	spin_unlock_irqrestore(&bdata->lock, flags);
+	spin_unlock(&bdata->lock);
 	return IRQ_HANDLED;
 }
 
-- 
2.25.1