lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87v8crkyj0.wl-tiwai@suse.de>
Date:   Sun, 03 Sep 2023 18:32:51 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Shenghao Ding <shenghao-ding@...com>
Cc:     <robh+dt@...nel.org>, <andriy.shevchenko@...ux.intel.com>,
        <lgirdwood@...il.com>, <perex@...ex.cz>,
        <pierre-louis.bossart@...ux.intel.com>, <kevin-lu@...com>,
        <13916275206@....com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>, <liam.r.girdwood@...el.com>,
        <mengdong.lin@...el.com>, <baojun.xu@...com>,
        <thomas.gfeller@...rop.com>, <peeyush@...com>, <navada@...com>,
        <broonie@...nel.org>, <gentuser@...il.com>
Subject: Re: [PATCH v1 1/2] ALSA: hda/tas2781: Update tas2781 HDA driver

On Sun, 03 Sep 2023 16:37:57 +0200,
Shenghao Ding wrote:
> 
> Support ACPI_ID both TXNW2781 and TIAS2781, and revert structure
> cs35l41_dev_name.

Could you explain why you need to revert?  That's the important
piece.

And, what is found in below...

> ---
> Changes in v1:
>  - Redefine tas2781_generic_fixup, remove hid param
>  - TIAS2781 has been used by our customers, see following dstd.dsl. We
>     have discussed this with them, they requested TIAS2781 must be
>     supported for the laptops already released to market, their new
>     laptops will switch to TXNW2781
>    Name (_HID, "TIAS2781")  // _HID: Hardware ID
>    Name (_UID, Zero)  // _UID: Unique ID
>    Method (_SUB, 0, NotSerialized)  // _SUB: Subsystem ID
>    {
>        If ((SPID == Zero))
>        {
>           Return ("17AA3886")
>        }
> 
>        If ((SPID == One))
>        {
>            Return ("17AA3884")
>        }

... such information should be mentioned in the changelog.
It can be even commented in the code.

Last but not least, if you do two things, split to two patches --
unless the rename is closely tied with the support of both IDs.


thanks,

Takashi

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ