linux-kernel - Re: [PATCH 2/2] power: supply: bq2515x: Some cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZPWtQDL5f0sgRJTM@smile.fi.intel.com>
Date:   Mon, 4 Sep 2023 13:11:12 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Biju Das <biju.das.au@...il.com>
Subject: Re: [PATCH 2/2] power: supply: bq2515x: Some cleanups

On Mon, Sep 04, 2023 at 01:10:04PM +0300, Andy Shevchenko wrote:
> On Sat, Sep 02, 2023 at 09:05:18PM +0100, Biju Das wrote:
> > Some cleanups:
> >  * Remove trailing comma in the terminator entry for OF/ID table.
> >  * Drop a space from terminator entry for OF table.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Btw, in all similar patches you may add the reason(s) why you are doing that:
> 
> 1/ unification;
> 2/ making code robust against (theoretical) misrebases or other similar things
>    where the new entry goes _after_ the termination without compiler noticing.

I.o.w. "terminator" has to "terminate" at run-time _and_ at compile-time.

-- 
With Best Regards,
Andy Shevchenko