linux-kernel - RE: [PATCH 1/2] power: supply: bq2515x: Simpilfy bq2515x_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB5922163C432F340877CF2A5A86F3A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Sun, 10 Sep 2023 07:03:05 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     Sebastian Reichel <sre@...nel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Biju Das <biju.das.au@...il.com>
Subject: RE: [PATCH 1/2] power: supply: bq2515x: Simpilfy
 bq2515x_read_properties() and probe()

Hi Andy Shevchenko,

> Subject: Re: [PATCH 1/2] power: supply: bq2515x: Simpilfy
> bq2515x_read_properties() and probe()
> 
> On Sat, Sep 02, 2023 at 09:05:17PM +0100, Biju Das wrote:
> > Add struct bq2515x_info and replace device_id->info in struct
> > bq2515x_device.
> >
> > Simpilfy bq2515x_read_properties() and probe() by adding struct
> > bq2425x_chip_info as match data for OF/ID tables and use
> > i2c_get_match_data for retrieving match data instead of ID lookup.
> >
> > Drop enum bq2515x_id as there is no user.
> 
> ...
> 
> > +/**
> > + * struct bq2515x_info -
> 
> Missing description.
I checked this and unfortunately other structures
in this driver are not adding description. So, for consistency, I am not doing it here.

Cheers,
Biju