linux-kernel - Re: [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Sep 2023 13:50:15 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Saravana Kannan <saravanak@...gle.com>, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Daniel Scally <djrscally@...il.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/1] device property: Clarify usage scope of some
 struct fwnode_handle members

On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote:
> Most of the struct fwnode_handle members are for exclusive use with
> device links framework. Clarify this by adding a respective comment.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Yes, this is important clarification.

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  include/linux/fwnode.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 5700451b300f..2a72f55d26eb 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -41,6 +41,8 @@ struct device;
>  struct fwnode_handle {
>  	struct fwnode_handle *secondary;
>  	const struct fwnode_operations *ops;
> +
> +	/* The below is used solely by device links, don't use otherwise */
>  	struct device *dev;
>  	struct list_head suppliers;
>  	struct list_head consumers;
> -- 
> 2.40.0.1.gaa8946217a0b

-- 
heikki