linux-kernel - RE: [PATCH 1/2] platform/mellanox: NVSW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR12MB5381C4AFCA22D823651F8F45AFE9A@BN9PR12MB5381.namprd12.prod.outlook.com>
Date:   Mon, 4 Sep 2023 12:25:03 +0000
From:   Vadim Pasternak <vadimp@...dia.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Andi Shyti <andi.shyti@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Michael Shych <michaelsh@...dia.com>,
        Wolfram Sang <wsa@...nel.org>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] platform/mellanox: NVSW_SN2201 should depend on ACPI



> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@...der.be>
> Sent: Monday, 4 September 2023 15:01
> To: Andi Shyti <andi.shyti@...nel.org>; Hans de Goede <hdegoede@...hat.com>;
> Mark Gross <markgross@...nel.org>; Vadim Pasternak <vadimp@...dia.com>;
> Michael Shych <michaelsh@...dia.com>; Wolfram Sang <wsa@...nel.org>
> Cc: linux-i2c@...r.kernel.org; platform-driver-x86@...r.kernel.org; linux-
> kernel@...r.kernel.org; Geert Uytterhoeven <geert+renesas@...der.be>
> Subject: [PATCH 1/2] platform/mellanox: NVSW_SN2201 should depend on ACPI
> 
> The only probing method supported by the Nvidia SN2201 platform driver is
> probing through an ACPI match table.  Hence add a dependency on ACPI, to
> prevent asking the user about this driver when configuring a kernel without ACPI
> support.
> 
> Fixes: 662f24826f954d49 ("platform/mellanox: Add support for new SN2201
> system")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Acked-by: Vadim Pasternak <vadimp@...dia.com>

> ---
>  drivers/platform/mellanox/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig
> index 382793e73a60a8b3..30b50920b278c94b 100644
> --- a/drivers/platform/mellanox/Kconfig
> +++ b/drivers/platform/mellanox/Kconfig
> @@ -80,8 +80,8 @@ config MLXBF_PMC
> 
>  config NVSW_SN2201
>  	tristate "Nvidia SN2201 platform driver support"
> -	depends on HWMON
> -	depends on I2C
> +	depends on HWMON && I2C
> +	depends on ACPI || COMPILE_TEST
>  	select REGMAP_I2C
>  	help
>  	  This driver provides support for the Nvidia SN2201 platform.
> --
> 2.34.1