linux-kernel - RE: [PATCH 2/2] i2c: I2C_MLXCPLD on ARM64 should depend on ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR12MB53812F432AE7060963A9FF4CAFE9A@BN9PR12MB5381.namprd12.prod.outlook.com>
Date:   Mon, 4 Sep 2023 12:25:18 +0000
From:   Vadim Pasternak <vadimp@...dia.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Andi Shyti <andi.shyti@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Michael Shych <michaelsh@...dia.com>,
        Wolfram Sang <wsa@...nel.org>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] i2c: I2C_MLXCPLD on ARM64 should depend on ACPI



> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@...der.be>
> Sent: Monday, 4 September 2023 15:01
> To: Andi Shyti <andi.shyti@...nel.org>; Hans de Goede <hdegoede@...hat.com>;
> Mark Gross <markgross@...nel.org>; Vadim Pasternak <vadimp@...dia.com>;
> Michael Shych <michaelsh@...dia.com>; Wolfram Sang <wsa@...nel.org>
> Cc: linux-i2c@...r.kernel.org; platform-driver-x86@...r.kernel.org; linux-
> kernel@...r.kernel.org; Geert Uytterhoeven <geert+renesas@...der.be>
> Subject: [PATCH 2/2] i2c: I2C_MLXCPLD on ARM64 should depend on ACPI
> 
> The "i2c_mlxcpld" platform device is only instantiated on X86 systems (through
> drivers/platform/x86/mlx-platform.c), or on ARM64 systems with ACPI (through
> drivers/platform/mellanox/nvsw-sn2201.c).  Hence further restrict the dependency
> on ARM64 to ACPI, to prevent asking the user about this driver when configuring
> an ARM64 kernel without ACPI support.
> 
> While at it, document in the Kconfig help text that the driver supports
> ARM64/ACPI based systems, too.
> 
> Fixes: d7cf993f832ad2a4 ("i2c: mlxcpld: Allow driver to run on ARM64
> architecture")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Acked-by: Vadim Pasternak <vadimp@...dia.com>

> ---
>  drivers/i2c/busses/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index
> 0aa97762332d8a87..bef2af50fb159baf 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -1391,10 +1391,10 @@ config I2C_ICY
> 
>  config I2C_MLXCPLD
>  	tristate "Mellanox I2C driver"
> -	depends on X86_64 || ARM64 || COMPILE_TEST
> +	depends on X86_64 || (ARM64 && ACPI) || COMPILE_TEST
>  	help
>  	  This exposes the Mellanox platform I2C busses to the linux I2C layer
> -	  for X86 based systems.
> +	  for X86 and ARM64/ACPI based systems.
>  	  Controller is implemented as CPLD logic.
> 
>  	  This driver can also be built as a module. If so, the module will be
> --
> 2.34.1