linux-kernel - [PATCH v2] ssb: Fix division by zero issue in ssb_calc_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230904232346.34991-1-rand.sec96@gmail.com>
Date:   Tue,  5 Sep 2023 02:23:46 +0300
From:   Rand Deeb <rand.sec96@...il.com>
To:     Michael Buesch <m@...s.ch>, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     deeb.rand@...fident.ru, lvc-project@...uxtesting.org,
        voskresenski.stanislav@...fident.ru,
        Rand Deeb <rand.sec96@...il.com>
Subject: [PATCH v2] ssb: Fix division by zero issue in ssb_calc_clock_rate

In ssb_calc_clock_rate(), there is a potential issue where the value of
m1 could be zero due to initialization using clkfactor_f6_resolv(). This
situation raised concerns about the possibility of a division by zero
error.

We fixed it by following the suggestions provided by Larry Finger
<Larry.Finger@...inger.net> and Michael Büsch <m@...s.ch>. The fix
involves returning a value of 1 instead of 0 in clkfactor_f6_resolv().
This modification ensures the proper functioning of the code and
eliminates the risk of division by zero errors.

Signed-off-by: Rand Deeb <rand.sec96@...il.com>
---
 drivers/ssb/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 0a26984acb2c..9e54bc7eec66 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -835,7 +835,7 @@ static u32 clkfactor_f6_resolve(u32 v)
 	case SSB_CHIPCO_CLK_F6_7:
 		return 7;
 	}
-	return 0;
+	return 1;
 }

 /* Calculate the speed the backplane would run at a given set of clockcontrol values */
-- 
2.34.1