linux-kernel - Re: [PATCH] Revert "printk: export symbols for debug modules"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230905132022.GA26718@lst.de>
Date:   Tue, 5 Sep 2023 15:20:22 +0200
From:   Christoph Hellwig <hch@....de>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Christoph Hellwig <hch@....de>, rostedt@...dmis.org,
        john.ogness@...utronix.de, senozhatsky@...omium.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        Yunlong Xing <yunlong.xing@...soc.com>, enlinmu@...il.com,
        yunlong.xing23@...il.com
Subject: Re: [PATCH] Revert "printk: export symbols for debug modules"

On Tue, Sep 05, 2023 at 11:54:37AM +0200, Petr Mladek wrote:
> Yeah, I did not have a good feeling about this patch.
> 
> I accepted it because there was an intention to upstream
> the module, see
> https://lore.kernel.org/all/CAAfh-jM0B2Cn579B0CkCrW44pJGGvjs112K+oMuViib+jDKafg@mail.gmail.com/
> 
> I think that it was bad decision. We should not export
> symbols when there is no in-tree user.

I think raw address to the printk buffer is a bad idea even for an
in-tree module.