linux-kernel - Re: [PATCH] Revert "printk: export symbols for debug modules"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZPb63crhycde0E0Q@alley>
Date:   Tue, 5 Sep 2023 11:54:37 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Christoph Hellwig <hch@....de>
Cc:     rostedt@...dmis.org, john.ogness@...utronix.de,
        senozhatsky@...omium.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org,
        Yunlong Xing <yunlong.xing@...soc.com>, enlinmu@...il.com,
        yunlong.xing23@...il.com
Subject: Re: [PATCH] Revert "printk: export symbols for debug modules"

Added people from the original thread into Cc.

On Tue 2023-09-05 10:19:02, Christoph Hellwig wrote:
> This reverts commit 3e00123a13d824d63072b1824c9da59cd78356d9.
> 
> No, we never export random symbols for out of tree modules.

Yeah, I did not have a good feeling about this patch.

I accepted it because there was an intention to upstream
the module, see
https://lore.kernel.org/all/CAAfh-jM0B2Cn579B0CkCrW44pJGGvjs112K+oMuViib+jDKafg@mail.gmail.com/

I think that it was bad decision. We should not export
symbols when there is no in-tree user.

> Signed-off-by: Christoph Hellwig <hch@....de>

Acked-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr