linux-kernel - Re: [PATCH 2/3] hwspinlock: qcom: Drop unused qcom,ipq6018-tcsr-mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd754243-a04f-466a-9c19-2163ee7008c4@quicinc.com>
Date:   Tue, 5 Sep 2023 15:26:09 +0530
From:   Vignesh Viswanathan <quic_viswanat@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <ohad@...ery.com>,
        <baolin.wang@...ux.alibaba.com>, <linux-remoteproc@...r.kernel.org>
CC:     <quic_kathirav@...cinc.com>, <quic_anusha@...cinc.com>,
        <quic_sjaganat@...cinc.com>, <quic_srichara@...cinc.com>,
        <quic_varada@...cinc.com>
Subject: Re: [PATCH 2/3] hwspinlock: qcom: Drop unused qcom,ipq6018-tcsr-mutex



On 9/4/2023 11:46 PM, Krzysztof Kozlowski wrote:
> On 04/09/2023 18:09, Vignesh Viswanathan wrote:
>>
>>
>> On 9/4/2023 9:31 PM, Konrad Dybcio wrote:
>>> On 4.09.2023 08:42, Krzysztof Kozlowski wrote:
>>>> On 04/09/2023 07:50, Vignesh Viswanathan wrote:
>>>>> qcom,ipq6018-tcsr-mutex maps to incorrect config of IPQ6018 and is
>>>>> dropped from the devictree.
>>>>
>>>> No, it is not dropped.
>>>>
>>>>
>>>>> IPQ6018 will use qcom,tcsr-mutex compatible
>>>>> string.
>>>>
>>>> No, it will not.
>>>>
>>>>>
>>>>> Drop qcom,ipq6018-tcsr-mutex compatible string from
>>>>> qcom_hwspinlock_of_match table.
>>>>
>>>> Why? Do not write what you are doing here, but why you are doing it.
>>> More importantly, looks like the ipq6018 compatible was added after
>>> support for this SoC was introduced (see f5e303aefc06 and 5bf635621245a),
>>> so if it's going to use of_tcsr_mutex data with the fallback compat, the
>>> SoC-specific compatible can be removed from the driver.
>>>
>> Hi Konrad, Krzysztof,
>>
>> I was planning to update the SOC-specific compatible for IPQ6018
>> qcom,ipq6018-tcsr-mutex to point to of_tcsr_mutex data in the of_match
>> table in the hwspinlock driver in V2.
>>
>> Do you think this would be okay? or should I go ahead with removal of
>> IPQ6018 specific compatible so that it falls back to of_tcsr_mutex?
> 
> Remove, it's not needed in the driver.

Ack, will remove in V2.
> 
> Best regards,
> Krzysztof
>