[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230905122827.GD184247@linux.intel.com>
Date: Tue, 5 Sep 2023 14:28:27 +0200
From: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Oded Gabbay <ogabbay@...nel.org>,
Dani Liberman <dliberman@...ana.ai>,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] accel/habanalabs/gaudi2: Fix incorrect string length
computation in gaudi2_psoc_razwi_get_engines()
On Mon, Sep 04, 2023 at 09:18:36PM +0200, Christophe JAILLET wrote:
> snprintf() returns the "number of characters which *would* be generated for
> the given input", not the size *really* generated.
>
> In order to avoid too large values for 'str_size' (and potential negative
> values for "PSOC_RAZWI_ENG_STR_SIZE - str_size") use scnprintf()
> instead of snprintf().
>
> Fixes: c0e6df916050 ("accel/habanalabs: fix address decode RAZWI handling")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
Powered by blists - more mailing lists