linux-kernel - Re: [PATCH] accel/habanalabs/gaudi2: Fix incorrect string length computation in gaudi2_psoc_razwi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf11LyA-pyq2kZ_oJhCtw_LCyx3h_a4JTurPvRNBFngzqcw@mail.gmail.com>
Date:   Wed, 13 Sep 2023 14:25:03 +0300
From:   Oded Gabbay <ogabbay@...nel.org>
To:     Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Dani Liberman <dliberman@...ana.ai>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] accel/habanalabs/gaudi2: Fix incorrect string length
 computation in gaudi2_psoc_razwi_get_engines()

On Tue, Sep 5, 2023 at 3:28 PM Stanislaw Gruszka
<stanislaw.gruszka@...ux.intel.com> wrote:
>
> On Mon, Sep 04, 2023 at 09:18:36PM +0200, Christophe JAILLET wrote:
> > snprintf() returns the "number of characters which *would* be generated for
> > the given input", not the size *really* generated.
> >
> > In order to avoid too large values for 'str_size' (and potential negative
> > values for "PSOC_RAZWI_ENG_STR_SIZE - str_size") use scnprintf()
> > instead of snprintf().
> >
> > Fixes: c0e6df916050 ("accel/habanalabs: fix address decode RAZWI handling")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
Applied to -next.
Thanks for the patch.
Oded