linux-kernel - Re: [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8395-evk board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Sep 2023 17:36:19 +0800
From:   Macpaul Lin <macpaul.lin@...iatek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Bernhard Rosenkränzer <bero@...libre.com>,
        Sean Wang <sean.wang@...iatek.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>
CC:     Bear Wang <bear.wang@...iatek.com>,
        Pablo Sun <pablo.sun@...iatek.com>,
        Macpaul Lin <macpaul@...il.com>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8395-evk
 board



On 9/4/23 20:11, Krzysztof Kozlowski wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On 04/09/2023 11:50, Macpaul Lin wrote:
>> 
>> 
>> On 9/4/23 17:33, Krzysztof Kozlowski wrote:
>>> 
>>>
>>> External email : Please do not click links or open attachments until you 
>>> have verified the sender or the content.
>>>
>>> On 04/09/2023 11:20, Macpaul Lin wrote:
>>>> Add bindings for the MediaTek mt8395-evk board.
>>>> The mt8359-evk board is also named as "Genio 1200-EVK".
>>>> MT8195 and MT8395 are the same family series SoC could share
>>>
>>> How can be the same and have different numbers? You sill need dedicated
>>> compatible.
>>>
>> 
>> The SoCs mt8195 and mt8395 are designed for different market application 
>> and physical characteristics, using different efuse values for 
>> distinction. The booting flow and configurations are controllered by the 
>> boot loaders, firmware, and TF-A. Therefore, the part numbers and 
>> procurement channels are different. The detail information of these 
>> efuse values is proprietary, so I cant disclose it futher. Hence the 
>> most of peripheral drivers and base address are almost the same.
> 
> 1. Drivers? So we talk about compatibility, not the same.
> 2. "almost the same" is not the same. Follow the guidelines for writing
> bindings.
> 

Thanks for the review.

After internal confirmation and discussion, it can be confirmed that the 
MT8195 and MT8395 are identical SoCs from to binding's perspective. 
MediaTek hope the mt8395 boards could directly use mt8195.dtsi, without 
the need to create a separate mt8395.dtsi to include mt8195.dtsi. 
Therefore, we hope to fully adopt the bindings of mt8195. However, I 
will submit a revised patch for compatible since they are different boards.

If the reviewer still disagrees, then MediaTek will create a new binding 
and use mt8395.dtsi to include mt8195.dtsi to apply the separate 
bindings for differentiation.

> Best regards,
> Krzysztof
> 
> 

Best regards,
Macpaul Lin