linux-kernel - Re: [PATCH v3 03/25] ima: Align ima_post_create_tmpfile() definition with LSM infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1a03980-11ea-c2a2-69c3-6137e69e5db9@linux.ibm.com>
Date:   Tue, 5 Sep 2023 13:26:35 -0400
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Roberto Sassu <roberto.sassu@...weicloud.com>,
        viro@...iv.linux.org.uk, brauner@...nel.org,
        chuck.lever@...cle.com, jlayton@...nel.org, neilb@...e.de,
        kolga@...app.com, Dai.Ngo@...cle.com, tom@...pey.com,
        zohar@...ux.ibm.com, dmitry.kasatkin@...il.com,
        paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
        dhowells@...hat.com, jarkko@...nel.org,
        stephen.smalley.work@...il.com, eparis@...isplace.org,
        casey@...aufler-ca.com
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-nfs@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, keyrings@...r.kernel.org,
        selinux@...r.kernel.org, Roberto Sassu <roberto.sassu@...wei.com>
Subject: Re: [PATCH v3 03/25] ima: Align ima_post_create_tmpfile() definition
 with LSM infrastructure

On 9/4/23 09:33, Roberto Sassu wrote:

> From: Roberto Sassu <roberto.sassu@...wei.com>
>
> Change ima_post_create_tmpfile() definition, so that it can be registered
> as implementation of the post_create_tmpfile hook.
>
> Signed-off-by: Roberto Sassu <roberto.sassu@...wei.com>
> ---
>   fs/namei.c                        | 2 +-
>   include/linux/ima.h               | 7 +++++--
>   security/integrity/ima/ima_main.c | 8 ++++++--
>   3 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index c5e96f716f98..1f5ec71360de 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -3698,7 +3698,7 @@ static int vfs_tmpfile(struct mnt_idmap *idmap,
>   		inode->i_state |= I_LINKABLE;
>   		spin_unlock(&inode->i_lock);
>   	}
> -	ima_post_create_tmpfile(idmap, inode);
> +	ima_post_create_tmpfile(idmap, dir, file, mode);
>   	return 0;
>   }
>   
> diff --git a/include/linux/ima.h b/include/linux/ima.h
> index 179ce52013b2..893c3b98b4d0 100644
> --- a/include/linux/ima.h
> +++ b/include/linux/ima.h
> @@ -19,7 +19,8 @@ extern enum hash_algo ima_get_current_hash_algo(void);
>   extern int ima_bprm_check(struct linux_binprm *bprm);
>   extern int ima_file_check(struct file *file, int mask);
>   extern void ima_post_create_tmpfile(struct mnt_idmap *idmap,
> -				    struct inode *inode);
> +				    struct inode *dir, struct file *file,
> +				    umode_t mode);
>   extern void ima_file_free(struct file *file);
>   extern int ima_file_mmap(struct file *file, unsigned long reqprot,
>   			 unsigned long prot, unsigned long flags);
> @@ -69,7 +70,9 @@ static inline int ima_file_check(struct file *file, int mask)
>   }
>   
>   static inline void ima_post_create_tmpfile(struct mnt_idmap *idmap,
> -					   struct inode *inode)
> +					   struct inode *dir,
> +					   struct file *file,
> +					   umode_t mode)
>   {
>   }
>   
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 76eba92d7f10..52e742d32f4b 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -663,16 +663,20 @@ EXPORT_SYMBOL_GPL(ima_inode_hash);
>   /**
>    * ima_post_create_tmpfile - mark newly created tmpfile as new
>    * @idmap: idmap of the mount the inode was found from
> - * @inode: inode of the newly created tmpfile
> + * @dir: inode structure of the parent of the new file
> + * @file: file descriptor of the new file
> + * @mode: mode of the new file
>    *
>    * No measuring, appraising or auditing of newly created tmpfiles is needed.
>    * Skip calling process_measurement(), but indicate which newly, created
>    * tmpfiles are in policy.
>    */
>   void ima_post_create_tmpfile(struct mnt_idmap *idmap,
> -			     struct inode *inode)
> +			     struct inode *dir, struct file *file,
> +			     umode_t mode)
>   {
>   	struct integrity_iint_cache *iint;
> +	struct inode *inode = file_inode(file);
>   	int must_appraise;
>   
>   	if (!ima_policy_flag || !S_ISREG(inode->i_mode))


Reviewed-by: Stefan Berger <stefanb@...ux.ibm.com>