linux-kernel - Re: [PATCH v2 2/5] dt-bindings: phy: qcom,qmp-usb: Add SDX75 USB3 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1838845b-9586-6f8c-a4d6-ef052e0a12db@quicinc.com>
Date:   Wed, 6 Sep 2023 10:56:05 +0530
From:   Rohit Agarwal <quic_rohiagar@...cinc.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <vkoul@...nel.org>,
        <kishon@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <gregkh@...uxfoundation.org>, <abel.vesa@...aro.org>,
        <quic_wcheng@...cinc.com>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-phy@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <kernel@...cinc.com>
Subject: Re: [PATCH v2 2/5] dt-bindings: phy: qcom,qmp-usb: Add SDX75 USB3 PHY


On 9/6/2023 10:52 AM, Rohit Agarwal wrote:
>
> On 9/6/2023 2:04 AM, Dmitry Baryshkov wrote:
>> On 05/09/2023 13:30, Rohit Agarwal wrote:
>>> Add dt-bindings for USB3 PHY found on Qualcomm SDX75.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@...cinc.com>
>>> ---
>>>   .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml        | 40 
>>> ++++++++++++++++++++--
>>>   1 file changed, 37 insertions(+), 3 deletions(-)
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml 
>>> b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml 
>>>
>>> index f99fbbc..5725620 100644
>>> --- 
>>> a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
>>> +++ 
>>> b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
>>> @@ -20,6 +20,7 @@ properties:
>>>         - qcom,qcm2290-qmp-usb3-phy
>>>         - qcom,sa8775p-qmp-usb3-uni-phy
>>>         - qcom,sc8280xp-qmp-usb3-uni-phy
>>> +      - qcom,sdx75-qmp-usb3-uni-phy
>>
>> I think the ident is wrong here.
>
> Same. Somehow, your reply has the issue but original not able to see.
>
>>
>>>         - qcom,sm6115-qmp-usb3-phy
>>>       reg:
>>> @@ -38,9 +39,7 @@ properties:
>>>       maxItems: 2
>>>       reset-names:
>>> -    items:
>>> -      - const: phy
>>> -      - const: phy_phy
>>> +    maxItems: 2
>>>       vdda-phy-supply: true
>>>   @@ -75,6 +74,7 @@ allOf:
>>>             contains:
>>>               enum:
>>>                 - qcom,ipq9574-qmp-usb3-phy
>>> +              - qcom,sdx75-qmp-usb3-uni-phy
>>>       then:
>>>         properties:
>>>           clock-names:
>>> @@ -122,6 +122,40 @@ allOf:
>>>         required:
>>>           - power-domains
>>>   +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - qcom,ipq9574-qmp-usb3-phy
>>> +              - qcom,qcm2290-qmp-usb3-phy
>>> +              - qcom,sa8775p-qmp-usb3-uni-phy
>>> +              - qcom,sc8280xp-qmp-usb3-uni-phy
>>> +              - qcom,sm6115-qmp-usb3-phy
>>> +    then:
>>> +      properties:
>>> +        resets:
>>> +          maxItems: 2
>>> +        reset-names:
>>> +          items:
>>> +            - const: phy
>>> +            - const: phy_phy
>>> +
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - qcom,sdx75-qmp-usb3-uni-phy
>>> +    then:
>>> +      properties:
>>> +        resets:
>>> +          maxItems: 2
>>> +        reset-names:
>>> +          items:
>>> +            - const: phy
>>> +            - const: common
>>
>> Could you please point us to the actual DTS patch adding this PHY? 
>> I'd say, it is highly likely that you are trying to bring in the 
>> unnecessary change.
> I have not posted the dt patches yet. But sdx75 uses these resets.
> GCC_USB3PHY_PHY_BCR, GCC_USB3_PHY_BCR
>
> These are same as sdx65 and sdx55.
Ok I see in your patch 
https://lore.kernel.org/linux-phy/20230824211952.1397699-17-dmitry.baryshkov@linaro.org/
you are updating the resets name. Fine, this change becomes unnecessary.
Will rebase my change on your patches.

Thanks,
Rohit.
>
> Thanks,
> Rohit.
>
>>
>>> +
>>>   additionalProperties: false
>>>     examples:
>>