linux-kernel - 回复: [PATCH v2 2/2] PM: hibernate: Fix the exclusive get block device in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Sep 2023 05:27:20 +0000
From:   "Feng, ChenzhouX" <chenzhoux.feng@...el.com>
To:     "Chen, Yu C" <yu.c.chen@...el.com>
CC:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Xu, Pengfei" <pengfei.xu@...el.com>,
        "syzbot+38d04642cea49f3a3d2e@...kaller.appspotmail.com" 
        <syzbot+38d04642cea49f3a3d2e@...kaller.appspotmail.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "Brown, Len" <len.brown@...el.com>, Pavel Machek <pavel@....cz>
Subject: 回复: [PATCH v2 2/2] PM: hibernate: Fix the exclusive get block device in test_resume mode



> -----邮件原件-----
> 发件人: Chen, Yu C <yu.c.chen@...el.com>
> 发送时间: Wednesday, September 6, 2023 12:19
> 收件人: Rafael J. Wysocki <rafael@...nel.org>; Brown, Len
> <len.brown@...el.com>; Pavel Machek <pavel@....cz>
> 抄送: linux-pm@...r.kernel.org; linux-kernel@...r.kernel.org; Feng, ChenzhouX
> <chenzhoux.feng@...el.com>; Xu, Pengfei <pengfei.xu@...el.com>; Chen, Yu C
> <yu.c.chen@...el.com>;
> syzbot+38d04642cea49f3a3d2e@...kaller.appspotmail.com
> 主题: [PATCH v2 2/2] PM: hibernate: Fix the exclusive get block device in
> test_resume mode
> 
> commit 5904de0d735b ("PM: hibernate: Do not get block device exclusively in
> test_resume mode") fixes a hibernation issue under test_resume mode.
> That commit is supposed to open the block device in non-exclusive mode when in
> test_resume. However the code did the opposite, which is against its description.
> 
> In summary, the swap device is only opened exclusively by swsusp_check() with
> its corresponding *close(), and must be in non test_resume mode.
> This is to avoid the race condition that different processes scribble the device at
> the same time. All the other cases should use non-exclusive mode.
> 
> Fix it by really disabling exclusive mode under test_resume.
> 
> Fixes: 5904de0d735b ("PM: hibernate: Do not get block device exclusively in
> test_resume mode")
> Reported-by: syzbot+38d04642cea49f3a3d2e@...kaller.appspotmail.com
> Closes:
> https://lore.kernel.org/lkml/000000000000761f5f0603324129@google.com/
> Reported-by: Pengfei Xu <pengfei.xu@...el.com>
> Signed-off-by: Chen Yu <yu.c.chen@...el.com>

It works on my machine, for the whole series,
Tested-by: Chenzhou Feng <chenzhoux.feng@...el.com>

thanks,
Chenzhou