linux-kernel - Re: [PATCH] LoongArch: add p?d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff90ca49-88b7-c2ab-d1b3-81e07eed5a97@loongson.cn>
Date:   Wed, 6 Sep 2023 16:22:55 +0800
From:   Hongchen Zhang <zhanghongchen@...ngson.cn>
To:     David Hildenbrand <david@...hat.com>,
        Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <kernel@...0n.name>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Mike Rapoport IBM)" <rppt@...nel.org>,
        Feiyang Chen <chenfeiyang@...ngson.cn>,
        Qi Zheng <zhengqi.arch@...edance.com>,
        "Matthew Wilcox Oracle)" <willy@...radead.org>,
        Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
        loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH] LoongArch: add p?d_leaf() definitions

On 2023/9/6 下午4:08, David Hildenbrand wrote:
> On 06.09.23 10:06, Hongchen Zhang wrote:
>> Hi David,
>>
>> On 2023/9/6 pm 3:42, David Hildenbrand wrote:
>>> On 05.09.23 08:49, Hongchen Zhang wrote:
>>>> When I do LTP test, LTP test case ksm06 caused panic at
>>>>      break_ksm_pmd_entry
>>>>        -> pmd_leaf (Huge page table but False)
>>>>        -> pte_present (panic)
>>>>
>>>
>>> Probably there are other problematic bits without that can trigger that?
>>> I suspect walk_page_range*() callers might be affected,
>> I rechecked the code and found that other architectures that support
>> THP have defined pmd_leaf.
>> So there is not problem on other architectures.
> 
> I meant other walk_page_range*() callers on loongarch might similarly be 
> affected. IOW, KSM might not be the only bit being able to trigger such 
> panics on loongarch.
Yes, perf_get_pgtable_size and vmalloc_to_page also call pmd_leaf.
So they may also trigger this issue on LoongArch.
> 


-- 
Best Regards
Hongchen Zhang