linux-kernel - Re: [PATCH] serial: sc16is7xx: remove unused to_sc16is7xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023090642-density-durably-c3ef@gregkh>
Date:   Wed, 6 Sep 2023 11:58:02 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Hugo Villeneuve <hugo@...ovil.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Hugo Villeneuve <hvilleneuve@...onoff.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-serial <linux-serial@...r.kernel.org>
Subject: Re: [PATCH] serial: sc16is7xx: remove unused to_sc16is7xx_port macro

On Wed, Sep 06, 2023 at 01:47:10PM +0300, Ilpo Järvinen wrote:
> On Tue, 5 Sep 2023, Hugo Villeneuve wrote:
> 
> > From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > 
> > This macro is not used anywhere.
> > 
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > ---
> >  drivers/tty/serial/sc16is7xx.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> > index f61d98e09dc3..d8534580c6d5 100644
> > --- a/drivers/tty/serial/sc16is7xx.c
> > +++ b/drivers/tty/serial/sc16is7xx.c
> > @@ -358,7 +358,6 @@ static struct uart_driver sc16is7xx_uart = {
> >  static void sc16is7xx_ier_set(struct uart_port *port, u8 bit);
> >  static void sc16is7xx_stop_tx(struct uart_port *port);
> >  
> > -#define to_sc16is7xx_port(p,e)	((container_of((p), struct sc16is7xx_port, e)))
> >  #define to_sc16is7xx_one(p,e)	((container_of((p), struct sc16is7xx_one, e)))
> >  
> >  static int sc16is7xx_line(struct uart_port *port)
> > 
> > base-commit: 3f86ed6ec0b390c033eae7f9c487a3fea268e027
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> 
> Note that Greg might be happier if you wait next time until after the 
> merge window is closed before sending non-fixes patch like this.

I just ignore them and add them to my review queue until after -rc1 is
out, not a problem at all.

thanks,

greg k-h