linux-kernel - Re: [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f92f14f3-de42-4c83-8c4c-02abc9730389@linaro.org>
Date:   Wed, 6 Sep 2023 14:07:07 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

On 6.09.2023 14:05, Krzysztof Kozlowski wrote:
> On 06/09/2023 13:50, Konrad Dybcio wrote:
>> On 6.09.2023 13:39, Krzysztof Kozlowski wrote:
>>> On 06/09/2023 13:28, Konrad Dybcio wrote:
>>>> On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
>>>>> According to schematics the VCCQ2 supply is not connected and the L3G
>>>>> regulator instead powers up the controller pads (VDD_PX10).  Use correct
>>>>> supply vdd-hba and drop unsupported current limit for the vdd-hba.
>>>> Why is it unsupported?
>>>
>>> Maybe I was here not precise. I move the regulator from vccq2 to
>>> vdd-hba. vccq2 has control of current in UFS core driver. Bindings also
>>> allow it.
>> Looks like the bindings are out of sync with the driver.
>>
>> ufshcd_populate_vreg() which parses current is used for both vccq2
>> and vdd-hba.
> 
> Just for convenience. The current is not used for vdd-hba. Also:
> 
> https://lore.kernel.org/all/20230906113302.201888-1-krzysztof.kozlowski@linaro.org/

I see, you're right.

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad