linux-kernel - Re: [PATCH v9 1/6] pwm: dwc: split pci out of core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230907211504.xfummvycltdj6bii@pengutronix.de>
Date:   Thu, 7 Sep 2023 23:15:04 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:     linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Greentime Hu <greentime.hu@...ive.com>,
        jarkko.nikula@...ux.intel.com,
        William Salmon <william.salmon@...ive.com>,
        Jude Onyenegecha <jude.onyenegecha@...ive.com>
Subject: Re: [PATCH v9 1/6] pwm: dwc: split pci out of core driver

Hello,

On Thu, Sep 07, 2023 at 05:12:37PM +0100, Ben Dooks wrote:
> Moving towards adding non-pci support for the driver, move the pci
> parts out of the core into their own module. This is partly due to
> the module_driver() code only being allowed once in a module and also
> to avoid a number of #ifdef if we build a single file in a system
> without pci support.
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

Great you continue here even though your commercial interest already
ended!

This series conflicts with my lifetime series[1], but I guess we can
sort that one when at least one of these two series is applied.

[1] https://lore.kernel.org/linux-pwm/20230808171931.944154-1-u.kleine-koenig@pengutronix.de/

> [...]
> diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
> index 3bbb26c862c3..bd9cadb497d7 100644
> --- a/drivers/pwm/pwm-dwc.c
> +++ b/drivers/pwm/pwm-dwc.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * DesignWare PWM Controller driver
> + * DesignWare PWM Controller driver (PCI part)
>   *
>   * Copyright (C) 2018-2020 Intel Corporation
>   *
> @@ -13,6 +13,8 @@
>   *   periods are one or more input clock periods long.
>   */
>  
> +#define DEFAULT_MOUDLE_NAMESPACE dwc_pwm
> +

There is no exported symbol in this driver, so this #define is unused.

>  #include <linux/bitops.h>
>  #include <linux/export.h>
>  #include <linux/kernel.h>

Otherwise looks fine:

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

(with or without dropping DEFAULT_MOUDLE_NAMESPACE from pwm-dwc.c)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)