[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2023090742-urology-relieve-660a@gregkh>
Date: Thu, 7 Sep 2023 15:43:08 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc: Pavan Bobba <opensource206@...il.com>,
Forest Bond <forest@...ttletooquiet.net>,
Michael Straube <straube.linux@...il.com>,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: vt6655: array names updated as per kernel
coding guidelines
On Thu, Sep 07, 2023 at 02:49:10PM +0200, Philipp Hortmann wrote:
> On 9/7/23 14:23, Pavan Bobba wrote:
> > Below array names updated as per coding guidelines:
> >
> > 1.byVT3253B0_AGC4_RFMD2959
> > 2.byVT3253B0_AIROHA2230
> > 3.byVT3253B0_UW2451
> > 4.byVT3253B0_AGC
> >
> > Conversions performed:
> > a.type encoding info dropped from names
> > b.names replaced by snakecase
> >
> > Issue found by checkpatch
> >
> > Signed-off-by: Pavan Bobba<opensource206@...il.com>
> > ---
> > v1 -> v2: 1.subject name modified to more meaningful detail
> > 2.name of the tool added in body of explanation,
> > which found this issue
>
> Hi Pavan,
>
> you did not fullfil what Greg wrote:
>
> - You did not write a descriptive Subject: for the patch, allowing Greg,
> and everyone else, to know what this patch is all about. Please read
> the section entitled "The canonical patch format" in the kernel file,
> Documentation/process/submitting-patches.rst for what a proper
> Subject: line should look like.
>
> The issue is that hundreds of patches could have this title: "array names
> updated as per kernel coding guidelines" Make it more unique.
>
> Rename CamelCase variable starting with byVT3253B0_
>
> Always consider that Greg reads a lot of patches per day.
Nor is the changelog written properly as per the documentation or the
zillion past changes for this driver :)
thanks,
greg k-h
Powered by blists - more mailing lists