linux-kernel - Re: [PATCH v2 17/41] mtd: spi-nor: atmel: convert flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9e60fe4-b7aa-4a13-b1b9-f4d3d429eb62@linaro.org>
Date:   Thu, 7 Sep 2023 10:45:59 +0100
From:   Tudor Ambarus <tudor.ambarus@...aro.org>
To:     Michael Walle <mwalle@...nel.org>
Cc:     Pratyush Yadav <pratyush@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v2 17/41] mtd: spi-nor: atmel: convert flash_info to new
 format



On 9/7/23 09:13, Michael Walle wrote:
>>> +    {
>>> +        .id = SNOR_ID(0x1f, 0x66, 0x01),
>>> +        .name = "at25fs010",
>>
>> nitpick, we shall respect the order of the members declared in
>> flash_info struct.
> 
> As mentioned in my first reply, you're fine with keeping the id
> first? After this series, we can swap the name and id members in
> struct flash_info.
> 
> For all the other members, they should be used consistently. So
> we could also swap the members in flash_info.

I'm ok, sounds good.
> 
>> And I'll let you double check if the conversion is accurate :D.
>>
>> Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> 
> So I'll convert that one in an Acked-by: for all the conversion
> patches?
> 

No, I'll add them afterwards, I'd like to check what I skipped on first
review.